Skip to content

fix(devicemanager): percision -> precision in motion calibration#10871

Merged
lanewei120 merged 1 commit into
bambulab:masterfrom
mvanhorn:osc/10856-fix-percision-typo
Jun 17, 2026
Merged

fix(devicemanager): percision -> precision in motion calibration#10871
lanewei120 merged 1 commit into
bambulab:masterfrom
mvanhorn:osc/10856-fix-percision-typo

Conversation

@mvanhorn

Copy link
Copy Markdown
Contributor

Summary

Closes #10856. The device status panel rendered "Measuring motion percision" and "Enhancing motion percision" during motion calibration (cases 36/37 in src/slic3r/GUI/DeviceManager.cpp:162,164). The intended word is precision. This PR fixes the source strings and updates the msgid keys in all 18 bbl/i18n/*.po files to match, so existing msgstr translations still resolve via gettext lookup.

Why this matters

These two strings are visible to every user who triggers motion calibration, so the typo is high-visibility in the device status panel. Updating only DeviceManager.cpp would silently break the gettext lookup for every translated locale (the existing msgid "Measuring motion percision" entries no longer match the corrected source, so gettext falls back to English and translators' work is dropped on the floor until the next extraction cycle).

Updating the msgid key on each .po file at the same time as the source keeps the existing msgstr translations attached to the corrected source string. Translators don't have to redo their work, and non-English users keep seeing translated text instead of falling back to the corrected English.

Changes

  • src/slic3r/GUI/DeviceManager.cpp:162,164 - percision -> precision in both _L(...) calls.
  • bbl/i18n/{cs,de,en,es,fr,hu,it,ja,ko,nl,pl,pt_BR,ru,sv,tr,uk,zh_CN,zh_TW}/BambuStudio_*.po - msgid keys updated to match. 18 files, 2 lines each.

Total: 19 files, 38 added + 38 deleted lines. Mechanical search-and-replace of two exact strings.

How to test

$ grep -rln "percision" --include="*.cpp" --include="*.po" --include="*.json" --include="*.h" .
(empty)
$ grep -n "Measuring motion precision\|Enhancing motion precision" src/slic3r/GUI/DeviceManager.cpp
162:        return _L("Measuring motion precision");
164:        return _L("Enhancing motion precision");

The 18 .po files each have two updated msgid lines; the matching msgstr translations are untouched.

Fixes #10856

AI-assisted.

`src/slic3r/GUI/DeviceManager.cpp` cases 36 and 37 displayed
"Measuring motion percision" and "Enhancing motion percision" in the
device status panel during motion calibration, visible to every user
who triggered the routine. The intended word is "precision".

Rename the source strings and update the matching `msgid` entries in
all 18 `bbl/i18n/*.po` translation files so the existing `msgstr`
translations still resolve via gettext lookup. Translations remain
intact - only the lookup key matches the corrected source.

Fixes bambulab#10856
@lanewei120

Copy link
Copy Markdown
Collaborator

Hi @mvanhorn

no need to modify the translation files in this patch,
please just modify the cpp files here

thanks

@BenJule

BenJule commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hi @mvanhorn — heads-up: #10809 fixes the same percisionprecision string (#10856) and is part of a small series of source-string cleanups (#10811/#10813/#10814), now all reduced to .cpp-only per @lanewei120's note here. Happy to defer to whichever the maintainers prefer — just flagging the overlap so we don't both land it. Thanks for catching this too!

@lanewei120 lanewei120 merged commit fe1a041 into bambulab:master Jun 17, 2026
14 of 17 checks passed
@lanewei120

Copy link
Copy Markdown
Collaborator

thanks for doing this~

@mvanhorn

Copy link
Copy Markdown
Contributor Author

Really appreciate the review, @lanewei120. Small one, but fixing percision to precision in the motion config panel was overdue.

@mvanhorn

Copy link
Copy Markdown
Contributor Author

Thanks @lanewei120 - good to get percision fixed to precision in the motion calibration panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants