Skip to content

fix: correct punctuation and grammar in UI warning/tip strings#10813

Merged
lanewei120 merged 1 commit into
bambulab:masterfrom
BenJule:fix/punctuation-spacing-ui-strings
Jun 22, 2026
Merged

fix: correct punctuation and grammar in UI warning/tip strings#10813
lanewei120 merged 1 commit into
bambulab:masterfrom
BenJule:fix/punctuation-spacing-ui-strings

Conversation

@BenJule

@BenJule BenJule commented May 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes missing spaces after Warning:, Error:, and Tip: prefixes, missing spaces after sentence-ending periods and commas, and several grammar errors in UI strings.

Files changed

File Issues fixed
GLGizmoText.cpp Warning:XWarning: X; create text failText creation failed; text normal is errorText normal has an error; reedit it will okreedit it to fix the issue; dragging textdrag the text; missing comma spaces
GLGizmoMeasure.cpp Warning:XWarning: X; two different meshtwo different meshes
GLGizmoSVG.cpp Tip:If...Tip: If...; missing comma; svg fileSVG file
PlaterWorker.hpp error occurederror occurred
DeviceManager.cpp filament(PLA...)filament (PLA...); missing spaces after . and ,
BindDialog.cpp device.Beforedevice. Before; termsandterms and; Use(collectively)Use (collectively)
ConfigManipulation.cpp Missing spaces after , and . in chamber temperature warning
AMSSetting.cpp 1 minute.The1 minute. The
Preferences.cpp tab.If change valuetab. If you change this value

Source-string changes only — the translation catalogs (bbl/i18n/*.po, BambuStudio.pot) are left to the upstream gettext pipeline, per maintainer guidance on #10871.

Closes #10853.

@Haidiye00

Copy link
Copy Markdown
Contributor
image Hello, please create a patch to submit. Additionally, the translation files do not need to be changed or submitted, as we have a dedicated translation web management system.
@Haidiye00

Copy link
Copy Markdown
Contributor
image Hello, if it's just a spacing issue, don't change it for now. Modifications are allowed if there are grammar or spelling errors.
@BenJule BenJule closed this Jun 7, 2026
@BenJule BenJule deleted the fix/punctuation-spacing-ui-strings branch June 7, 2026 10:09
@BenJule BenJule restored the fix/punctuation-spacing-ui-strings branch June 7, 2026 11:39
@BenJule BenJule reopened this Jun 7, 2026
@BenJule

BenJule commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change.

It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused.

Adds missing spaces after 'Warning:'/'Error:'/'Tip:' prefixes and fixes
grammar in user-facing strings across several GUI source files. Source-string
changes only; translation catalogs are left to the upstream gettext pipeline.

Closes bambulab#10853
@BenJule BenJule force-pushed the fix/punctuation-spacing-ui-strings branch from 952926e to ebe38af Compare June 8, 2026 05:10
@BenJule

BenJule commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Force-pushed: rebased onto current master and reduced this PR to the source-string changes only. The previous revision had inadvertently carried translation-file (.po/.pot) edits and a few unrelated files over from the branch base — those are now removed. Per @lanewei120's guidance on #10871, the .po/.pot catalogs are left to the upstream translation pipeline.

@lanewei120

Copy link
Copy Markdown
Collaborator

thanks @BenJule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants