Skip to content

fix: correct grammar and punctuation in English UI strings#10811

Open
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/english-grammar-typos
Open

fix: correct grammar and punctuation in English UI strings#10811
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/english-grammar-typos

Conversation

@BenJule

@BenJule BenJule commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Four English grammar/spelling/punctuation errors corrected in UI strings displayed to users:

File Before After
src/slic3r/GUI/MediaPlayCtrl.cpp "Problem occured." "Problem occurred."
src/slic3r/GUI/SelectMachine.cpp "When enable spiral vase mode…" "When enabling spiral vase mode…"
src/slic3r/GUI/SyncAmsInfoDialog.cpp "When enable spiral vase mode…" "When enabling spiral vase mode…"
src/slic3r/GUI/Gizmos/GLGizmoAdvancedCut.cpp "connectors is out of object" "connectors are out of object"
src/slic3r/GUI/Gizmos/GLGizmoText.cpp "Error:Detecting …outcomes.Please drag…" "Error: Detecting …outcomes. Please drag…"

Source-string changes only — the translation catalogs (bbl/i18n/*.po, BambuStudio.pot) are left to the upstream gettext pipeline, per maintainer guidance on #10871.

Closes #10854.
@BenJule BenJule force-pushed the fix/english-grammar-typos branch from 6e9167e to 03c26d6 Compare May 20, 2026 14:56
@BenJule BenJule mentioned this pull request May 21, 2026
Open
@BenJule BenJule force-pushed the fix/english-grammar-typos branch 2 times, most recently from 0e4fcfa to a1ab267 Compare May 21, 2026 08:55
@BenJule BenJule closed this Jun 7, 2026
@BenJule BenJule deleted the fix/english-grammar-typos branch June 7, 2026 10:09
@BenJule BenJule restored the fix/english-grammar-typos branch June 7, 2026 11:39
@BenJule BenJule reopened this Jun 7, 2026
@BenJule

BenJule commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Apologies — this PR was closed by mistake on 2026-06-07, and that was an error on my side, not a deliberate decision to withdraw the change.

It happened as an unintended side effect of a branch cleanup in my fork: deleting the head branch automatically closed this PR. The contribution still stands. I have restored the branch and reopened the PR. Sorry for the noise and any confusion this caused.
@BenJule
fix(ui): correct grammar and spelling in English UI strings
2cb9575 
Fixes typos/grammar in user-facing strings (e.g. 'occured' -> 'occurred',
'When enable' -> 'When enabled', stray connector words) across several GUI
source files. Source-string changes only; translation catalogs are left to
the upstream gettext pipeline.

Closes bambulab#10854
@BenJule BenJule force-pushed the fix/english-grammar-typos branch from a1ab267 to 2cb9575 Compare June 8, 2026 05:10
@BenJule

BenJule commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Force-pushed: rebased onto current master and reduced this PR to the source-string changes only. The previous revision had inadvertently carried translation-file (.po/.pot) edits and a few unrelated files over from the branch base — those are now removed. Per @lanewei120's guidance on #10871, the .po/.pot catalogs are left to the upstream translation pipeline.
This was referenced Jun 8, 2026
Merged
Closed
Open
Open
Open
Closed
@BambulabRobot BambulabRobot requested review from Haidiye00 and XinZhangBambu and removed request for FiredEgg-bambu and MackBambu June 22, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@BenJule