Fix add_to_pydotorg session cleanup calls - #411
Merged
Conversation
sethmlarson
approved these changes
Jun 15, 2026
hugovk
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #403, fixing its interaction with the shared requests session introduced in #390.
delete_object()now uses the module-levelsession, matching the other API helpers, and thepost_object()failure test now patchesadd_to_pydotorg.session.postinstead ofrequests.post.Tests
tox -q -e py313 -- tests/test_add_to_pydotorg.py::test_post_object_raises_on_failure tests/test_add_to_pydotorg.py::test_delete_object_uses_session tests/test_add_to_pydotorg.py::test_create_release_files_cleans_up_created_rowstox -q -e linttox -q -e mypy