Skip to content

Fail add_to_pydotorg on release-file create failures - #403

Merged
hugovk merged 1 commit into
python:mainfrom
e-q:fail-add-to-pydotorg-create-errors
Jun 15, 2026
Merged

Fail add_to_pydotorg on release-file create failures#403
hugovk merged 1 commit into
python:mainfrom
e-q:fail-add-to-pydotorg-create-errors

Conversation

@e-q

@e-q e-q commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • raise an error when creating a release-file API object fails
  • clean up release-file rows created earlier in the same run if a later create
    fails
  • add focused tests for create failure reporting and cleanup behavior

Closes #398

Tests

  • Focused pytest coverage for post_object and create_release_files: passed.
  • Ruff lint and format checks on touched files: passed.
  • Direct repository mypy check through an existing mypy environment: passed.
  • Whitespace check: passed.
@python-cla-bot

python-cla-bot Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
hugovk
hugovk approved these changes Jun 12, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the 3.14.6 release with this branch, everything uploaded fine.

https://www.python.org/downloads/release/python-3146/
@hugovk
hugovk merged commit 77aa07c into python:main Jun 15, 2026
18 checks passed
@e-q e-q mentioned this pull request Jun 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@e-q @hugovk @sethmlarson