Zend/tests: merge constant_expressions into constexpr, update names - #17872
Merged
Conversation
Member
Author
|
CC @TimWolla who caught the duplicate directories |
TimWolla
reviewed
Feb 21, 2025
| @@ -1,5 +1,5 @@ | |||
| --TEST-- | |||
| Invalid operation in new arg in const expr | |||
| Valid operation in new arg in const expr | |||
Member
There was a problem hiding this comment.
This one is interesting, because AFAICT it no longer is a constexpr context since https://wiki.php.net/rfc/arbitrary_static_variable_initializers
Member
There was a problem hiding this comment.
Indeed, guess I forgot to update the test description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the existing tests in the
constexprdirectory, I found that some of the names were not updated to reflect the contents when the contents were changed in #9301.Follow-up to #15638