Zend/tests: organize some tests with sub directories

[DanielEScherzer]

Move some low-hanging fruit, creating new directories for the tests for

• access modifiers
• class_alias()
• constant expressions
• constructor property promotion
• __debugInfo()
• dereferencing
• first class callable syntax

Additionally, move some tests into the existing sub directory for closure-related tests

Work towards GH-15631

[DanielEScherzer]

@Girgias can I get your thoughts on this? Having recently had to scroll through the list of Zend tests a number of times for other recent patches, this would really come in handy

[Girgias]

I am overall in favour of this sort of changes as needing to run all the Zend tests when just checking one specific part is very time-consuming, and does lead to wasted CI time when one thinks one has run all the tests but in reality no.

[DanielEScherzer]

Not sure why GitHub was reporting a merge conflict, git rebase master worked perfectly

[Girgias]

Thank you. :)

[TimWolla]

Since this PR we have both:

https://github.com/php/php-src/tree/master/Zend/tests/constexpr

and

https://github.com/php/php-src/tree/master/Zend/tests/constant_expressions

which is probably not a good idea. For #17213 (which should land at the end of the week), I've now opted for Zend/tests/first_class_callable/constexpr/. But Zend/tests/constexpr/first_class_callable/attributes.phpt (with constexpr and first_class_callable reversed) would also work.

[DanielEScherzer]

Since this PR we have both:

https://github.com/php/php-src/tree/master/Zend/tests/constexpr

and

https://github.com/php/php-src/tree/master/Zend/tests/constant_expressions

which is probably not a good idea. For #17213 (which should land at the end of the week), I've now opted for Zend/tests/first_class_callable/constexpr/. But Zend/tests/constexpr/first_class_callable/attributes.phpt (with constexpr and first_class_callable reversed) would also work.

Sorry about that - based on the names I assumed that they referred to two different contexts, but I guess not. Do you want me to merge those directories?

[TimWolla]

Do you want me to merge those directories?

Please double-check that they are indeed referring to the same thing and then merge them, yes. Keep the constexpr one, it's the older one.