Skip to content

New CI color and background image - #37650

Merged
phil-davis merged 1 commit into
masterfrom
new-ci-colors-20200704
Jul 4, 2020
Merged

New CI color and background image#37650
phil-davis merged 1 commit into
masterfrom
new-ci-colors-20200704

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

This PR changes the CI color project wide and adds a new background image for the login screen.
This will adapt ownCloud to the new style guide.

How Has This Been Tested?

  • manually tested

Screenshots (if appropriate):

Types of changes

  • Non-breaking change
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE
@phil-davis
phil-davis requested a review from ChrisEdS July 3, 2020 17:38
@phil-davis phil-davis self-assigned this Jul 3, 2020
@phil-davis

phil-davis commented Jul 3, 2020

Copy link
Copy Markdown
Contributor Author

This is an updated version of #37628 with a better core/img/background.jpg that does not cause problems in the UI acceptance tests.

PR #37649 has commits that demonstrated the problem with the previous core/img/background.jpg and that the new one passes.

This was referenced Jul 3, 2020
@codecov

codecov Bot commented Jul 3, 2020

Copy link
Copy Markdown

Codecov Report

Merging #37650 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37650   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
  Complexity    19360    19360           
=========================================
  Files          1281     1281           
  Lines         75622    75622           
  Branches       1333     1333           
=========================================
  Hits          48959    48959           
  Misses        26271    26271           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.92% <100.00%> (ø) 19360.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...ilesharing/templates/settings-personal-general.php 100.00% <ø> (ø) 0.00 <0.00> (ø)
core/templates/layout.base.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
core/templates/layout.guest.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
core/templates/layout.user.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
apps/dav/lib/HookManager.php 53.33% <100.00%> (ø) 17.00 <0.00> (ø)
lib/private/legacy/defaults.php 59.25% <100.00%> (ø) 45.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1cf18...fa8bb2e. Read the comment docs.

@ChrisEdS ChrisEdS left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking care.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Note: this PR goes into master. If the merge-back of the current release-10.5.0 branch happens ( #37648 ) then this will automatically end up in the new release-10.5.0 branch that gets started next week.

Otherwise this will need to be backport to release-10.5.0

@phil-davis
phil-davis merged commit 50519f4 into master Jul 4, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the new-ci-colors-20200704 branch July 4, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants