Skip to content

New colors and CI - #37628

Closed
ChrisEdS wants to merge 1 commit into
release-10.5.0from
new-ci-colors
Closed

New colors and CI#37628
ChrisEdS wants to merge 1 commit into
release-10.5.0from
new-ci-colors

Conversation

@ChrisEdS

@ChrisEdS ChrisEdS commented Jul 2, 2020

Copy link
Copy Markdown

Description

This PR changes the CI color project wide and adds a new background image for the login screen.
This will adapt ownCloud to the new style guide.

How Has This Been Tested?

  • Manually tested

Screenshot:

image

Types of changes

  • Non-breaking change
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE
@ChrisEdS ChrisEdS added this to the development milestone Jul 2, 2020
@ChrisEdS ChrisEdS self-assigned this Jul 2, 2020
@update-docs

update-docs Bot commented Jul 2, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis

Copy link
Copy Markdown
Contributor

@pmaier1 should there be a changelog entry written about this?

@pmaier1

pmaier1 commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

@pmaier1 should there be a changelog entry written about this?

Yes. Thanks for catching that!

@ChrisEdS

ChrisEdS commented Jul 2, 2020

Copy link
Copy Markdown
Author

@pmaier1 should there be a changelog entry written about this?

Done.

@phil-davis

Copy link
Copy Markdown
Contributor

Note: there are no text strings changed here, so no impact on translations. So this is fine to just be merged into the release branch, and it will "appear" in master when the release branch is merged back to master...

@phil-davis
phil-davis force-pushed the new-ci-colors branch 3 times, most recently from 942c456 to dafbd22 Compare July 2, 2020 16:19
@ChrisEdS
ChrisEdS force-pushed the new-ci-colors branch 2 times, most recently from 1acbe8e to 3409f34 Compare July 2, 2020 18:16
@phil-davis

Copy link
Copy Markdown
Contributor

This gets some crazy fail in webUI tests, e.g. https://drone.owncloud.com/owncloud/core/25720/107/15

  Scenario: simple user login                                                                 # /drone/src/tests/acceptance/features/webUILogin/login.feature:23
    Given these users have been created with default attributes and without skeleton files:   # FeatureContext::theseUsersHaveBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
      | username |
      | Alice    |
    When user "Alice" logs in using the webUI                                                 # WebUILoginContext::logInWithUsernameUsingTheWebUI()
      unknown error: session deleted because of page crash
      from tab crashed
        (Session info: chrome=74.0.3729.169)
        (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.15.0-106-generic x86_64) (WebDriver\Exception\UnknownError)
    Then the user should be redirected to a webUI page with the title "Files - %productname%" # WebUIGeneralContext::theUserShouldBeRedirectedToAWebUIPageWithTheTitle()
SCENARIO RESULT: (fail)

Need to work out why such a simply color changes causes this.

@phil-davis phil-davis mentioned this pull request Jul 3, 2020
11 tasks
@phil-davis

Copy link
Copy Markdown
Contributor

In #37649 I am adding these changes piece-by-piece to see exactly what triggers the browser crash.

@phil-davis phil-davis mentioned this pull request Jul 3, 2020
11 tasks
@phil-davis

Copy link
Copy Markdown
Contributor

See #37650 for a new PR that should pass.

@micbar micbar closed this Jul 8, 2020
@phil-davis
phil-davis deleted the new-ci-colors branch July 8, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment