Fix: Form Builder: Set subscriber as active when Tag/Sequence set

[n7studios]

Summary

Fixes Form Builder blocks with only a Tag and/or Sequence set (no Kit Form) creating subscribers as inactive.

#1084 creates the subscriber as inactive when a Kit Form is specified, so the Form's double opt-in setting is honored, and active otherwise, as there's no double opt-in for Tags or Sequences. However, the block always outputs a hidden form_id field, which is 0 when no Form is selected. The check $form_id !== false was therefore always true, so every subscriber was created as inactive, including those from Tag or Sequence only blocks.

Form, Tag and Sequence IDs are now cast to integers, and the subscriber is only created as inactive when a Form ID is set. This restores the behaviour from before #1084 for Tag and Sequence only blocks, and matches the Contact Form 7, Forminator and WishList Member integrations, which only use inactive for Forms.

The behaviour when a Form is specified is unchanged.

Testing

New Integration tests in BlockFormBuilderTest, mocking Kit API requests:

• testSubscriberInactiveWhenFormSpecified: the subscriber is created as inactive and added to the Form.
• testSubscriberActiveWhenTagSpecified: the subscriber is created as active and tagged. Fails on main.
• testSubscriberActiveWhenSequenceSpecified: the subscriber is created as active and added to the Sequence.
• PageBlockFormBuilderCest: testFormBuilderBlockWithTaggingEnabled and testFormBuilderBlockWithSequenceEnabled now also assert the subscriber is active.

Checklist

• I have written a test and included it in this PR
• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

[github-actions]

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground