Form Builder: Set inactive subscriber state when a Kit Form is used - #1084
Merged
Merged
Conversation
6 tasks done
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
n7studios
requested review from
a team,
ciccio-kit and
noelherrick
and removed request for
a team
April 30, 2026 05:56
n7studios
marked this pull request as ready for review
April 30, 2026 05:56
noelherrick
reviewed
Apr 30, 2026
noelherrick
left a comment
noelherrick
left a comment
Contributor
There was a problem hiding this comment.
Can you write a test that makes sure that the subscriber is active on a single-opt-in form? I can see that the forms endpoint should handle this, but since you're using the subscriber endpoint, I just want to confirm it will follow the form activation rules
WordPress Playground🚀 Your PR has been built and is ready for testing in WordPress Playground! |
noelherrick
approved these changes
May 4, 2026
Form Builder: Support Legacy Forms
Tests: Integrations: Set `inactive` subscriber state when a Kit Form is used
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this reported issue by creating a subscriber with state of
inactivewhen the Form Builder block is set to subscribe the email address to a Kit Form.This allows the form's single / double opt in to be honored, which creators expect, and matches how this works for Contact Form 7, Forminator and WishList Member.
Testing
testFormBuilderBlockWithSingleOptinFormEnabled: Test the Form Builder block works when added and that the subscriber's state is active when a single optin Form is specified.testFormBuilderBlockWithDoubleOptinFormEnabled: Test the Form Builder block works when added and that the subscriber's state is inactive when a double optin Form is specified.Checklist