Skip to content

fix: emit pass for empty generated classes - #100

Open
kellen-miller wants to merge 1 commit into
sqlc-dev:mainfrom
kellen-miller:fix/empty-generated-classes
Open

fix: emit pass for empty generated classes#100
kellen-miller wants to merge 1 commit into
sqlc-dev:mainfrom
kellen-miller:fix/empty-generated-classes

Conversation

@kellen-miller

Copy link
Copy Markdown

Summary

  • emit pass for empty generated classes
  • add printer coverage for empty class bodies
  • add a zero-parameter query_parameter_limit: 0 regression fixture

Root cause

When query_parameter_limit: 0 is enabled, zero-parameter queries still emit a params class. If that class has no fields, the generated Python class body is empty, which produces invalid syntax.

Validation

  • go test ./internal/printer
  • built the plugin locally and reproduced the zero-parameter query case in a temp directory, confirming CountBarsParams now emits pass

Closes #99.

@kellen-miller
kellen-miller marked this pull request as ready for review April 20, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant