Fix config discovery under Native AOT (GitBuf marshalling) - #2188
Open
kzu wants to merge 1 commit into
Open
Conversation
Under Native AOT, sequential-layout class marshalling for GitBuf is effectively [In]-only, so git_config_find_* succeeds but managed ptr stays zero and global/system config never loads. BuildSignature then returns null when user.name/email live outside local repo config. Use a blittable GitBufNative struct with ref P/Invoke for path-find APIs and ConvertPath so config discovery works in AOT publishes. Fixes libgit2#2187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitBufmarshalling does not writeptr/sizeback to managed code aftergit_config_find_*.Configuration.BuildSignaturereturn null whenuser.name/user.emailare only in global config (including viainclude.path).GitBufNativeand userefP/Invoke for path-find APIs andConvertPath, so config discovery matches CoreCLR/dotnet runbehavior.Root cause (brief)
Under Native AOT, class-based sequential marshalling is effectively
[In]-only.git_config_find_globalcan return success while managedGitBuf.ptrstays zero, so discovery returns no path and only local repo config is loaded.Test plan
LibGit2Sharpfor all TFMsrepo.Config.BuildSignature:HasConfig(Global)/HasConfig(System)true, signature non-null when identity is in global configdotnet runpath still resolves global config and builds signatureFixes #2187