fix: reject unresolved POST and PUT references - #876
Open
henriquejsza wants to merge 1 commit into
Open
Conversation
Fail fast when a string reference cannot be resolved for an effective POST or PUT object. This prevents write requests from silently invalidating or skipping the object and returning a successful response. Add DB-free regression coverage for table and non-table references, CRUD method directives, preserved GET and DELETE behavior, and resolved references. closes Tencent#275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST/PUTobjects withUnsupportedOperationExceptionGET,DELETE, and resolved-reference behaviorCRUD→@postdispatchThis prevents an out-of-order write reference from silently skipping the write while the parser returns success.
Validation
mvn -Dtest=AbstractObjectParserReferenceTest test— 8 passedmvn clean verify— 36 passedThe core APIJSONORM path was tested; the APIJSON-Demo
/registerendpoint was not retested.Fixes #275