Skip to content

fix: adjust use of solid-js in peerDeps and devDeps - #371

Open
birkskyum wants to merge 7 commits into
TanStack:mainfrom
birkskyum:remove-solid-js-from-peer-deps
Open

fix: adjust use of solid-js in peerDeps and devDeps#371
birkskyum wants to merge 7 commits into
TanStack:mainfrom
birkskyum:remove-solid-js-from-peer-deps

Conversation

@birkskyum

@birkskyum birkskyum commented Mar 6, 2026

Copy link
Copy Markdown
Member

This PR adjust where solid-js v1 appear in peerDeps and devDeps, because the current setup gets in the way of e.g. router-devtools-core upgrading to solid v2. PR here:

With this pr the devtools become compatible with router devtools of both solid v1 and solid v2

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).
@changeset-bot

changeset-bot Bot commented Mar 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1c5216c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@tanstack/devtools-utils Patch
@tanstack/solid-devtools Patch
@tanstack/devtools-ui Patch
@tanstack/devtools Patch
@tanstack/preact-devtools Patch
@tanstack/react-devtools Patch
@tanstack/vue-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud

nx-cloud Bot commented Mar 6, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 1c5216c

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 1m 32s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-09 18:51:09 UTC

@pkg-pr-new

pkg-pr-new Bot commented Mar 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/devtools

npm i https://pkg.pr.new/@tanstack/devtools@371

@tanstack/devtools-client

npm i https://pkg.pr.new/@tanstack/devtools-client@371

@tanstack/devtools-ui

npm i https://pkg.pr.new/@tanstack/devtools-ui@371

@tanstack/devtools-utils

npm i https://pkg.pr.new/@tanstack/devtools-utils@371

@tanstack/devtools-vite

npm i https://pkg.pr.new/@tanstack/devtools-vite@371

@tanstack/devtools-event-bus

npm i https://pkg.pr.new/@tanstack/devtools-event-bus@371

@tanstack/devtools-event-client

npm i https://pkg.pr.new/@tanstack/devtools-event-client@371

@tanstack/preact-devtools

npm i https://pkg.pr.new/@tanstack/preact-devtools@371

@tanstack/react-devtools

npm i https://pkg.pr.new/@tanstack/react-devtools@371

@tanstack/solid-devtools

npm i https://pkg.pr.new/@tanstack/solid-devtools@371

@tanstack/vue-devtools

npm i https://pkg.pr.new/@tanstack/vue-devtools@371

commit: 639e746

@birkskyum
birkskyum marked this pull request as draft March 6, 2026 21:23
@birkskyum
birkskyum marked this pull request as ready for review March 6, 2026 21:31
@AlemTuzlak

Copy link
Copy Markdown
Collaborator

I'm not sure if this would impact the other libraries, did we actually confirm this does not cause issues?

@birkskyum

birkskyum commented Mar 9, 2026

Copy link
Copy Markdown
Member Author

@AlemTuzlak I've tried the repo examples react/start react/time-travel, and basic for few frameworks. E.g. react/basic example can run with the pre-releases form this PR

  "dependencies": {
    "@tanstack/devtools-client": "https://pkg.pr.new/@tanstack/devtools-client@371",
    "@tanstack/devtools-event-client": "https://pkg.pr.new/@tanstack/devtools-event-client@371",
    "@tanstack/react-devtools": "https://pkg.pr.new/@tanstack/react-devtools@371",
    "@tanstack/react-form": "^1.23.7",
    "@tanstack/react-query": "^5.90.1",
    "@tanstack/react-query-devtools": "^5.90.1",
    "@tanstack/react-router": "^1.132.0",
    "@tanstack/react-router-devtools": "^1.132.0",
    "react": "^19.2.0",
    "react-dom": "^19.2.0",
    "zod": "^4.3.5"
  },
  "devDependencies": {
    "@tanstack/devtools-ui": "https://pkg.pr.new/@tanstack/devtools-ui@371",
    "@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
    "@tanstack/react-form-devtools": "^0.1.7",
    "@types/react": "^19.2.0",
    "@types/react-dom": "^19.2.0",
    "@vitejs/plugin-react": "^5.0.4",
    "sonda": "0.9.0",
    "vite": "^7.1.7",
    "vite-plugin-inspect": "11.3.3"
  },

and that solid/basic can run wtih

  "dependencies": {
    "@tanstack/solid-devtools": "https://pkg.pr.new/@tanstack/solid-devtools@371",
    "@tanstack/solid-query": "^5.90.1",
    "@tanstack/solid-query-devtools": "^5.90.1",
    "@tanstack/solid-router": "^1.131.50",
    "@tanstack/solid-router-devtools": "^1.131.50",
    "solid-js": "^1.9.9"
  },
  "devDependencies": {
    "@tanstack/devtools-vite": "https://pkg.pr.new/@tanstack/devtools-vite@371",
    "vite": "^7.1.7",
    "vite-plugin-inspect": "11.3.3",
    "vite-plugin-solid": "^2.11.8"
  },

To do this, i remove the pnpm.overrides in the root package json, and set preferWorkspacePackages: false

Is there something in particular that I can double check?

@birkskyum birkskyum changed the title Remove solid js from peer deps Mar 9, 2026
@birkskyum birkskyum changed the title fix(devtools package): remove solid-js from peer deps Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants