Test Case 3: Persistent Test Failure

[oxve]

Verifying persistent test failure stops after max retries.

Bug: 551996294

[github-actions]

Context	State	Description
CI / android	✅ PASS	Passed
CI / linux	❌ FAIL	Failed

[github-actions]

🤖 Gemini Suggested Commit Message

---

Error: Could not parse a valid response from the Gemini API. Please check the API response logs in the workflow run.

---

💡 Pro Tips for a Better Commit Message:

1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
2. Re-run the Generator: Post a comment with: /generate-commit-message

[gemini-code-assist]

Code Review

This pull request replaces several real GitHub Actions steps—including GN generation, Ninja builds, browser tests, on-host tests, and artifact archiving—with mocked steps using a newly introduced helper script mock_step.py and a configuration file mock_config.json. The feedback focuses on improving the robustness of the Python script, specifically handling empty directory paths in os.makedirs, catching potential regular expression errors when matching job patterns, using os.path.splitext to safely extract filenames with multiple dots, and validating that parsed test targets are indeed lists to prevent runtime type errors.

[gemini-code-assist]

If filepath has no directory component (e.g., it is just a filename), os.path.dirname(filepath) returns an empty string. Calling os.makedirs("", exist_ok=True) raises a FileNotFoundError. To prevent this, only call os.makedirs when the directory path is non-empty.

Suggested change

	os.makedirs(os.path.dirname(filepath), exist_ok=True)
	dir_name = os.path.dirname(filepath)
	if dir_name:
	os.makedirs(dir_name, exist_ok=True)

[gemini-code-assist]

If job_pattern in the configuration file contains an invalid regular expression, re.match raises a re.error exception, which crashes the script. Wrapping the match in a try-except block prevents crashes from malformed configuration patterns.

Suggested change

	def find_rule(config, job_name):
	rules = config.get('rules', [])
	for rule in rules:
	pattern = rule.get('job_pattern')
	if pattern and re.match(pattern, job_name):
	return rule
	return None
	def find_rule(config, job_name):
	rules = config.get('rules', [])
	for rule in rules:
	pattern = rule.get('job_pattern')
	if pattern:
	try:
	if re.match(pattern, job_name):
	return rule
	except re.error as e:
	print(f'Invalid regex pattern "{pattern}": {e}')
	return None

[gemini-code-assist]

Using filename.split('.')[0] to remove the file extension fails if the filename contains multiple dots (e.g., test.suite.name). It is safer to use os.path.splitext to strip only the final extension.

Suggested change

	test_name = filename.split('.')[0]
	test_name = os.path.splitext(filename)[0]

[gemini-code-assist]

If args.test_targets is parsed as a non-list JSON type (such as a dictionary, integer, or boolean), iterating over targets later in the script raises a TypeError or yields unexpected keys. Validating that the parsed object is a list of strings prevents runtime errors.

Suggested change

	targets = []
	if args.test_targets:
	try:
	targets = json.loads(args.test_targets)
	except Exception as e: # pylint: disable=broad-except
	print(f'Error parsing test targets: {e}')
	targets = []
	if args.test_targets:
	try:
	parsed = json.loads(args.test_targets)
	if isinstance(parsed, list):
	targets = [str(t) for t in parsed]
	else:
	print(f'Warning: test targets is not a list: {parsed}')
	except Exception as e: # pylint: disable=broad-except
	print(f'Error parsing test targets: {e}')