Update 1.4.11 Non-text Contrast to address concerns about visual boundaries#5064
Open
patrickhlauke wants to merge 8 commits intomainfrom
Open
Update 1.4.11 Non-text Contrast to address concerns about visual boundaries#5064patrickhlauke wants to merge 8 commits intomainfrom
patrickhlauke wants to merge 8 commits intomainfrom
Conversation
…daries Originally, "placeholder" was mentioned in passing in the "Boundaries" section. However, if placeholder text is the only "text inside the control", as soon as a user enters a single empty character, the input - if it has low contrast border - would immediately fail 1.4.11 (as then there's no indication anymore giving users a hint about the presence of the control). This PR rewrites the whole boundaries explanation to hopefully make it clearer when boundaries are needed and when they're not, and why. Further, this adds a new failure example to the "Failing User Interface Component Examples" table - an input without any containing text and low contrast border - and it tweaks the preceding example of an input with a custom caret to be just about the caret (and not ALSO have low contrast border), so make it clearer what the failure here is. Closes #4413
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
adampage
approved these changes
Apr 15, 2026
Member
adampage
left a comment
There was a problem hiding this comment.
Looks great. 🚀 I left some suggestions for SVG hygiene and editorial tweaks.
…-no-label-fail.svg Co-authored-by: Adam Page <adam@adampage.net>
Co-authored-by: Adam Page <adam@adampage.net>
Co-authored-by: Adam Page <adam@adampage.net>
Co-authored-by: Adam Page <adam@adampage.net>
Contributor
|
For Figure 1, might we have Button1, Button2 (rather than Button, Button) ? |
Member
Author
they're supposed to be the same button, non-focused and then focused |
patrickhlauke
commented
May 1, 2026
bruce-usab
reviewed
May 1, 2026
Co-authored-by: Bruce Bailey <bruce@bailey4.us>
bruce-usab
approved these changes
May 1, 2026
Contributor
|
@adampage this update will likely impact your redesign of the page content. |
Member
This one is considerably more important. 😅 But, yeah, I’m monitoring and will reconcile any conflicts once I get there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, "placeholder" was mentioned in passing in the "Boundaries" section. However, if placeholder text is the only "text inside the control", as soon as a user enters a single empty character, the input - if it has low contrast border - would immediately fail 1.4.11 (as then there's no indication anymore giving users a hint about the presence of the control).
This PR rewrites the whole boundaries explanation to hopefully make it clearer when boundaries are needed and when they're not, and why.
Further, this adds a new failure example to the "Failing User Interface Component Examples" table - an input without any containing text and low contrast border - and it tweaks the preceding example of an input with a custom caret to be just about the caret (and not ALSO have low contrast border), so make it clearer what the failure here is.
Closes #4413
Preview: https://deploy-preview-5064--wcag2.netlify.app/understanding/non-text-contrast
(specifically https://deploy-preview-5064--wcag2.netlify.app/understanding/non-text-contrast#boundaries and the second table - the failing examples - in https://deploy-preview-5064--wcag2.netlify.app/understanding/non-text-contrast#user-interface-component-examples)
Diff preview at Boundaries