Fix note structure in abbreviation definition#4452
Merged
Conversation
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mbgower
added
ErratumRaised
bruce-usab
approved these changes
Jun 20, 2025
Contributor
|
@alastc out of an abundance of caution, I am putting this into the quarterly errata column, pending a discussion with you. |
Contributor
Merged
kfranqueiro
added a commit
that referenced
this pull request
Oct 29, 2025
Fixes #4436. This fixes the markup for the first top-level note in the abbreviations definition to use a `div`, so that it can properly wrap the ordered list that is supposed to exist inside of it (as it did in [WCAG 2.0](https://www.w3.org/TR/WCAG20/#abbreviationsdef)). This also relegates the nested note to an inline annotation in a paragraph (suggested by Alastair), to avoid needing to worry about an unimplemented nesting edge case. The diff will be easier to view with whitespace ignored (`?w=1`). @netlify /guidelines/#dfn-abbreviations Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk> Co-authored-by: Mike Gower <mikegower@gmail.com> (cherry picked from commit 172fe84)
kfranqueiro
added a commit
that referenced
this pull request
Oct 31, 2025
Fixes #4436. This fixes the markup for the first top-level note in the abbreviations definition to use a `div`, so that it can properly wrap the ordered list that is supposed to exist inside of it (as it did in [WCAG 2.0](https://www.w3.org/TR/WCAG20/#abbreviationsdef)). This also relegates the nested note to an inline annotation in a paragraph (suggested by Alastair), to avoid needing to worry about an unimplemented nesting edge case. The diff will be easier to view with whitespace ignored (`?w=1`). @netlify /guidelines/#dfn-abbreviations Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk> Co-authored-by: Mike Gower <mikegower@gmail.com> (cherry picked from commit 172fe84)
mbgower
added a commit
that referenced
this pull request
Oct 31, 2025
Updates the errata documents for 2.2 and 2.1 to list the 6 new editorial changes held for the quarterly update. These are: - Rewording the normative preamble of Content on Hover or Focus for clarity ([#4469](#4469)) - Changing occurrences of "e-mail" to "email" ([#4385](#4385)) - Removing use of "must" in section 7 preamble ([#4458](#4458)) - Fixing the markup for the notes in the "abbreviation" definition ([#4452](#4452)) - Changing capitalized occurrences of "Web" and "Success Criteria" to match the established lower-case style ([#4461](#4461)) - Restyling the boxed links for the Understanding and How to Meet... documents ([#4590](#4590)) --------- Co-authored-by: Kenneth G. Franqueiro <kfranqueiro@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4436.
This fixes the markup for the first top-level note in the abbreviations definition to use a
div, so that it can properly wrap the ordered list that is supposed to exist inside of it (as it did in WCAG 2.0).This also relegates the nested note to an inline annotation in a paragraph (suggested by Alastair), to avoid needing to worry about an unimplemented nesting edge case.
The diff will be easier to view with whitespace ignored (
?w=1).@netlify /guidelines/#dfn-abbreviations