Skip to content

sort: remove redundant if #10716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oech3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sort: remove redundant if #10716

oech3 wants to merge 1 commit into from
+8 −19

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 4, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
sylvestre
sylvestre reviewed Feb 4, 2026
View reviewed changes
src/uu/sort/src/sort.rs
if matches.get_flag(options::modes::RANDOM) {
mode_flags.random = true;
}
let mut mode_flags = ModeFlags {
Copy link
Contributor

@sylvestre sylvestre Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, well done :)
@xtqqczze
Copy link
Contributor

xtqqczze commented Feb 4, 2026

It would be even better if we could avoid accessing private fields outside of ModeFlags implementation.
@oech3 oech3 marked this pull request as ready for review February 4, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@oech3 @xtqqczze @sylvestre