refactor: drop unreachable arm64 branch in LinuxBuilder.getFileName#1291
Open
LuisMIguelFurlanettoSousa wants to merge 1 commit into
Open
Conversation
In getFileName the inner check 'if (this.buildArch === "arm64" && ...)' sat inside the else of 'if (this.buildArch === "arm64")', so this.buildArch is provably never 'arm64' at that point and the branch (and its 'aarch64' assignment) can never run. Remove it and flatten the nested else into an else-if chain; the arm64 -> aarch64 mapping is already handled by the first branch, so behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1290
What
The inner
if (this.buildArch === 'arm64' && ...)ingetFileName()sits inside theelseofif (this.buildArch === 'arm64'), sothis.buildArchis provably never'arm64'there — the branch and itsaarch64assignment are unreachable. The arm64 → aarch64 mapping is already handled by the first branch.Change
Remove the dead branch and flatten the nested
else { if }into anelse ifchain.dist/cli.jsrebuilt.Verify
Behavior-preserving; full suite passes:
205 passed;
pnpm run format:checkclean.