chore: activate no-unused-vars and import linters#4096
Open
carderne wants to merge 22 commits into
Open
Conversation
|
Contributor
|
Important Review skippedToo many files! This PR contains 846 files, which is 696 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (846)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
![devin-ai-integration[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
carderne
force-pushed
the
chore/more-lints
branch
from
09e6512 to
d6d5c68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this is merged, oxlint is at a pretty sensible baseline.
Enable
no-unused-vars,typescript/consistent-type-imports, andimport/no-duplicateslint rulesTurns on three previously-disabled oxlint rules across the monorepo and fixes all violations:
no-unused-vars– enabled as an error with standard ignore patterns: unused function arguments are ignored by default (args: "none"), variables/caught errors/destructured array elements prefixed with_are allowed, and rest siblings are permitted.typescript/consistent-type-imports– enforced as an error; all type-only imports now use theimport typesyntax.import/no-duplicates– enforced as an error; duplicate import statements from the same module have been merged.The remaining commits clean up the violations found across the codebase: removing unused variables/imports/type aliases, adding
_prefixes to intentionally unused bindings, fixing duplicate imports, and converting value imports toimport typewhere appropriate.