fix: remove dead HomeTriggerDevBanner import that breaks the lint gate#218
Open
simon-vincent wants to merge 1 commit into
Open
fix: remove dead HomeTriggerDevBanner import that breaks the lint gate#218simon-vincent wants to merge 1 commit into
simon-vincent wants to merge 1 commit into
Conversation
The HomeTriggerDevBanner component was removed from the repo but its import in app/routes/index.tsx remained. The symbol is never rendered, so this is a dangling import that breaks `tsc` (and therefore the `npm run lint` gate that CONTRIBUTING.md asks every contributor to run) on a clean checkout of main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes a dangling import in
app/routes/index.tsx:-import { HomeTriggerDevBanner } from "~/components/Home/HomeTriggerDevBanner";Why
The
HomeTriggerDevBannercomponent no longer exists in the repo (onlyHomeApiHeroBannerandHomeGithubBannerremain underapp/components/Home/). The import was left behind and the symbol is never rendered in the page's JSX, so it is pure dead code.Because the file is still imported,
tscfails on a clean checkout ofmain:This breaks
npm run lint— the exact gate that CONTRIBUTING.md asks every contributor to run ("Make sure to run thenpm lintcommand to ensure there are no Typescript compile-time errors"). The esbuild dev/prod bundles tree-shake the unused import, so the app itself is unaffected — only the type-check fails.Verification
On this branch, all gates pass:
npm run lint✅ (was failing onmain)npm test✅ (20/20)npm run build✅No behaviour change — the homepage renders identically.