Skip to content

[vulkan] Let VMA grab fptrs itself #8672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobcao3 merged 3 commits into from
Apr 13, 2025
Merged

[vulkan] Let VMA grab fptrs itself #8672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f9c7c4
Let VMA grab fptrs itself
bobcao3 Apr 7, 2025
00b68b0
Update vulkan_device.cpp
bobcao3 Apr 7, 2025
c55783a
Update vulkan_memory_allocator.cpp
bobcao3 Apr 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions taichi/rhi/vulkan/vulkan_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2455,9 +2455,12 @@ void VulkanDevice::create_vma_allocator() {
allocatorInfo.device = device_;
allocatorInfo.instance = instance_;

VolkDeviceTable table;
VmaVulkanFunctions vk_vma_functions{nullptr};
VmaVulkanFunctions vk_vma_functions{};
vk_vma_functions.vkGetInstanceProcAddr = vkGetInstanceProcAddr;
vk_vma_functions.vkGetDeviceProcAddr = vkGetDeviceProcAddr;

// Let VMA grab the functions by itself
/*
volkLoadDeviceTable(&table, device_);
vk_vma_functions.vkGetPhysicalDeviceProperties =
PFN_vkGetPhysicalDeviceProperties(vkGetInstanceProcAddr(
Expand Down Expand Up @@ -2499,6 +2502,7 @@ void VulkanDevice::create_vma_allocator() {
table.vkGetDeviceBufferMemoryRequirements;
vk_vma_functions.vkGetDeviceImageMemoryRequirements =
table.vkGetDeviceImageMemoryRequirements;
*/

allocatorInfo.pVulkanFunctions = &vk_vma_functions;

Expand Down
2 changes: 1 addition & 1 deletion taichi/rhi/vulkan/vulkan_memory_allocator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

#define VMA_IMPLEMENTATION
#define VMA_DEDICATED_ALLOCATION 0
#define VMA_DYNAMIC_VULKAN_FUNCTIONS 0
#define VMA_DYNAMIC_VULKAN_FUNCTIONS 1
#include "vk_mem_alloc.h"