chore: Sync the vendored UI with upstream antora-ui-default, part 3: CSS stuff - #926
Draft
lfrancke wants to merge 12 commits into
Draft
chore: Sync the vendored UI with upstream antora-ui-default, part 3: CSS stuff#926lfrancke wants to merge 12 commits into
lfrancke wants to merge 12 commits into
Conversation
Comma-separated selector lists can end up carrying the same selector twice when both the fork and upstream add it at different positions in the list. CSS ignores the repeat, but stylelint's no-duplicate-selectors treats it as an error and the production playbook fails builds on warnings. Keeps upstream's position for the selector so the file converges on upstream and the next re-sync has less to reconcile. Co-Authored-By: Claude <noreply@anthropic.com>
The marker carried no SHA, so there was no way to tell what a re-sync would have to look at. It now names 0e38223a and says plainly that the range is not fully applied: the search UI, typefaces, tabs and the highlight.js language set have diverged far enough that upstream's versions do not apply, and some commits were already present from earlier cherry-picks. Drops a pointer to a plan file outside the repository. It named a path under a home directory, so it resolved for nobody, and the file is not there. Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See these two previous ones for details on the "why":
Note
Similar to last time: I want a review, but the merge has to be a force merge due to the CLA stuff. This is explained in an earlier PR and is part of the readme or some other file