Skip to content

Encapsulate Split::Algorithms at our own module to avoid explicit calling rubystats everywhere - #674

Merged
andrehjr merged 2 commits into
mainfrom
encapsulate_ruby_stats
Mar 4, 2022
Merged

Encapsulate Split::Algorithms at our own module to avoid explicit calling rubystats everywhere#674
andrehjr merged 2 commits into
mainfrom
encapsulate_ruby_stats

Conversation

@andrehjr

@andrehjr andrehjr commented Mar 4, 2022

Copy link
Copy Markdown
Member
  • Encapsulates RubyStats on its own module. Avoiding calling it from other places in code. Split just needs the BetaDistribution.
  • Warns if matrix is not installed (stblib made it into a gem). Although this should be fixed on rubystats upstream, for now, we try to warn users and to make our own specs pass.
@andrehjr
andrehjr merged commit 0474494 into main Mar 4, 2022
@andrehjr
andrehjr deleted the encapsulate_ruby_stats branch March 4, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant