Skip to content

Fix Bigdecimal warnings - #551

Merged
andrehjr merged 1 commit into
splitrb:masterfrom
agraves:ag-squelch-bigdecimal-warning
Mar 6, 2019
Merged

Fix Bigdecimal warnings#551
andrehjr merged 1 commit into
splitrb:masterfrom
agraves:ag-squelch-bigdecimal-warning

Conversation

@agraves

@agraves agraves commented Mar 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • replace BigDecimal.new() with BigDecimal()
  • 3.3.1 and HEAD are affected, most likely affects historical versions as well
  • this resolves the following deprecation warning when running Ruby >= 2.5.0rc1:
/Users/username/src/project/.gems/gems/split-3.3.1/lib/split/dashboard/helpers.rb:24: warning: BigDecimal.new is deprecated; use BigDecimal() method instead.
@agraves
Fix Bigdecimal warnings
4a4f202 
* replace BigDecimal.new() with BigDecimal()
@andrehjr

andrehjr commented Mar 6, 2019

Copy link
Copy Markdown
Member

Thanks @agraves !
@andrehjr
andrehjr merged commit a1a8a74 into splitrb:master Mar 6, 2019
@giraffate giraffate mentioned this pull request Aug 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@agraves @andrehjr