Avoid hitting up on redis for robots/excluded users. - #544
Merged
Conversation
andrehjr
force-pushed
the
exclude-visitor-before-loading-experiment
branch
from
April 3, 2019 16:22
1a6d3f5 to
7f0bf4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482
When Split is disabled or user is excluded, we avoid hitting redis up to load/save the experiment.
This should save a few calls if the a/b is exposed on a public page, or something.
The helper still follows up the logic of building an Split::Experiment to correctly return the control alternative.
Note that on this moment
ExperimentCatalog.find_or_initializedoes actually hit redis to 'find' an existing experiment.