Populate enclosing_range on SCIP definition Occurrences - #250
Merged
Conversation
jupblb
suggested changes
Jul 2, 2026
jupblb
left a comment
jupblb
left a comment
Contributor
There was a problem hiding this comment.
Hi! This PR looks good to me but the snapshot formatting is a bit off. Can you fix that?
See:
- https://github.com/scip-code/scip/blob/0d18012fcb33891ca771b0c9f818910399c0a176/scip.proto#L747-L797
- https://github.com/scip-code/scip-go/blob/17b27afd9b772ee676ab39d74e563a4495772fd3/internal/testdata/snapshots/output/pr198/pr198.go#L34-L47
- https://github.com/scip-code/scip-go/blob/17b27afd9b772ee676ab39d74e563a4495772fd3/internal/testdata/snapshots/output/initial/rangefunc.go#L9-L35
jjuliamolin
force-pushed
the
enclosing-range
branch
from
July 2, 2026 14:31
bcf77a6 to
da700af
Compare
Contributor
Author
|
Fixed, but was a bit too quick to push, locals look a bit weird, let me fix that |
jupblb
approved these changes
Jul 2, 2026
Contributor
|
Will wait for the fix, thanks for leaving a comment about it :) |
jjuliamolin
force-pushed
the
enclosing-range
branch
from
July 2, 2026 16:35
da700af to
df1ee2c
Compare
jjuliamolin
force-pushed
the
enclosing-range
branch
from
July 2, 2026 16:40
df1ee2c to
67989c6
Compare
Contributor
Author
Done, removed enclosing_range for all locals, seems like we don't have proper span for them anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding enclosing_range to Occurences to capture the whole span of definitions.
Test: regold snapshots