Skip to content

diff: support renamed, updated binary file - #38

Merged
keegancsmith merged 1 commit into
sourcegraph:masterfrom
stephen:master
Aug 19, 2020
Merged

diff: support renamed, updated binary file#38
keegancsmith merged 1 commit into
sourcegraph:masterfrom
stephen:master

Conversation

@stephen

@stephen stephen commented Nov 15, 2019

Copy link
Copy Markdown
Contributor

This commit parses a diff with a renamed, updated binary file and adds a test case for it.

@codecov

codecov Bot commented Nov 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #38 into master will decrease coverage by 2.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   29.48%   27.24%   -2.25%     
==========================================
  Files           5        5              
  Lines        1177     1138      -39     
==========================================
- Hits          347      310      -37     
  Misses        784      784              
+ Partials       46       44       -2     
Impacted Files Coverage Δ
diff/parse.go 79.93% <100.00%> (-2.12%) ⬇️
diff/print.go 44.73% <0.00%> (-0.95%) ⬇️
diff/diff.go 86.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b8bb2...1e7398a. Read the comment docs.

@unknwon

unknwon commented Nov 16, 2019

Copy link
Copy Markdown

Thanks for the PR!

I am not the best to review this code but .DS_Store definitely shouldn't be committed :)

@mrnugget mrnugget left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! But, as @unknwon pointed out, please remove the .DS_Store file from the diff 🙂

@keegancsmith

Copy link
Copy Markdown
Member

@stephen ping :)

@stephen
stephen force-pushed the master branch 2 times, most recently from 9001611 to 94f220e Compare August 18, 2020 21:19
This commit parses a diff with a renamed, updated binary file and
adds a test case for it.
@stephen

stephen commented Aug 18, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the reminder. I removed the .DS_Store and rebased to fix conflicts. I tried to match the changes in f935979 in my new diff.

@stephen

stephen commented Aug 18, 2020

Copy link
Copy Markdown
Contributor Author

Separately, adding .DS_Store to a .gitignore might be nice.

@keegancsmith
keegancsmith merged commit b49127c into sourcegraph:master Aug 19, 2020
@keegancsmith

Copy link
Copy Markdown
Member

Thanks!

sofiia-tesliuk pushed a commit to sofiia-tesliuk/go-diff that referenced this pull request Aug 25, 2020
This commit parses a diff with a renamed, updated binary file and adds a test
case for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants