Skip to content

use github.com/sourcegraph/go-diff import path instead of custom sourcegraph.com/... import path - #30

Merged
sqs merged 1 commit into
masterfrom
github-import-path
Mar 24, 2019
Merged

use github.com/sourcegraph/go-diff import path instead of custom sourcegraph.com/... import path#30
sqs merged 1 commit into
masterfrom
github-import-path

Conversation

@sqs

@sqs sqs commented Mar 24, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@sqs
sqs force-pushed the github-import-path branch from 97e3e6d to eda26d8 Compare March 24, 2019 18:20
@sqs
sqs force-pushed the github-import-path branch from eda26d8 to de643bf Compare March 24, 2019 18:23
@codecov

codecov Bot commented Mar 24, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@dee78e5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   26.91%           
=========================================
  Files             ?        5           
  Lines             ?     1133           
  Branches          ?        0           
=========================================
  Hits              ?      305           
  Misses            ?      784           
  Partials          ?       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee78e5...de643bf. Read the comment docs.

@sqs
sqs merged commit c825d9a into master Mar 24, 2019
@dmitshur

Copy link
Copy Markdown
Contributor

README still says go get -u sourcegraph.com/sourcegraph/go-diff/diff and uses the previous import path in the godoc.org badge. Is that unintentional?

sqs added a commit that referenced this pull request Mar 24, 2019
@sqs sqs mentioned this pull request Mar 24, 2019
sqs added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Mar 24, 2019
@sqs
sqs deleted the github-import-path branch March 24, 2019 22:13
@sqs

sqs commented Mar 24, 2019

Copy link
Copy Markdown
Contributor Author

(#30 (comment) fixed in #32, thanks!)

sqs added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Mar 24, 2019
dmitshur added a commit to shurcooL/home that referenced this pull request Mar 25, 2019
emidoots pushed a commit to sourcegraph/go-vcs that referenced this pull request Apr 9, 2019
dmitshur added a commit to shurcooL-legacy/Conception-go that referenced this pull request Apr 15, 2019
dmitshur added a commit to shurcooL-legacy/Conception-go that referenced this pull request Apr 15, 2019
DABH pushed a commit to DABH/changes that referenced this pull request May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants