Keep legacy selectors connected to current versions - #1849
Open
HawkSE wants to merge 1 commit into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a04534-2413-71c9-ac1f-51d83bd1fdbc Co-authored-by: Scott Ellison II <scott.ellison@sourcegraph.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
enriquegh
requested changes
Aug 31, 2026
| const versionsUrl = | ||
| process.env.NEXT_PUBLIC_DOCS_VERSIONS_URL ?? | ||
| 'https://sourcegraph.com/docs/api/versions'; | ||
| 'https://sourcegraph-docs-git-main-sourcegraph-f8c71130.vercel.app/docs/api/versions'; |
Contributor
There was a problem hiding this comment.
hmm is this URL safe to use? Will it always point to main?
Can we see if the Security team has any advice on how to accomplish this? If we must, I think a better URL would be https://sourcegraph-docs-v2.vercel.app/docs as that seems to be static to our main deployment but I'd prefer if we kept this to sourcegraph.com domain
valerybugakov
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainVercel origin, avoiding Cloudflare challenges on cross-subdomain browser requestsTest plan
npx --yes pnpm@10.25.0 run build