Skip to content

initial commit for this **EXPERIMENTAL** branch - #93

Draft
kporangehat wants to merge 1 commit into
masterfrom
33017_requests
Draft

initial commit for this **EXPERIMENTAL** branch#93
kporangehat wants to merge 1 commit into
masterfrom
33017_requests

Conversation

@kporangehat

Copy link
Copy Markdown

Not for merging. just for review.

Adds ShotgunMulti object which inherits from Shotgun and is returned when setting the multi_thread=True parameter when instantiating Shotgun. This object uses the requests module instead of httplib2/urllib.
Adds callbacks to the upload() and download_attachment() methods which receive a ShotgunProgressMonitor object for use when handling progress info.
More to come.

Adds `ShotgunMulti` object which inherits from Shotgun and is returned when setting the multi_thread=True parameter when instantiating Shotgun. This object uses the requests module instead of httplib2/urllib.
Adds callbacks to the upload() and download_attachment() methods which receive a ShotgunProgressMonitor object for use when handling progress info.
More to come.
@manneohrstrom

Copy link
Copy Markdown
Contributor

This is exciting! @sgsteph should watch this space :)

@sgsteph

sgsteph commented Nov 6, 2015

Copy link
Copy Markdown
Contributor

I definetely do ;)

Stéphane Deverly

Le 5 nov. 2015 à 22:21, Manne Öhrström notifications@github.com a écrit :

This is exciting! @sgsteph should watch this space :)


Reply to this email directly or view it on GitHub.

@kporangehat

Copy link
Copy Markdown
Author

heh... lots of this is about to change :). Moving away from the subclassing and going to make this much more independent. Updates coming hopefully very soon!

@cmihaly

cmihaly commented Nov 6, 2015

Copy link
Copy Markdown

Very exciting to see these changes! Chris

Sent from my iPad

On Nov 5, 2015, at 10:25 PM, KP notifications@github.com wrote:

heh... lots of this is about to change :). Moving away from the subclassing and going to make this much more independent. Updates coming hopefully very soon!


Reply to this email directly or view it on GitHub.

@sgsteph

sgsteph commented Nov 6, 2015

Copy link
Copy Markdown
Contributor

A quick heads up that I had issues with requests.get and https://sg-media-usor-01.s3.amazonaws.com urls and ended up having verify=False for my download requests. By default, verify is True I think.

@kporangehat

Copy link
Copy Markdown
Author

@sgsteph interesting. I did not run into any issues on my end. Were the issues simply verification failures or something else?

@monkeydev

Copy link
Copy Markdown

The error was :
Error reported: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)
I didn’t have the issue on my laptop but on remote servers where I deployed a service.

On 06 Nov 2015, at 18:18, KP notifications@github.com wrote:

@sgsteph https://github.com/sgsteph interesting. I did not run into any issues on my end. Were the issues simply verification failures or something else?


Reply to this email directly or view it on GitHub #93 (comment).

@carlos-villavicencio-adsk
carlos-villavicencio-adsk marked this pull request as draft January 29, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants