Trigger "repositioned" event after position change - #196
Merged
Conversation
|
Hey, thanks it works great for my usecase you can release that :) I use react-tether and had to hack a bit the library so that it supports something like: <TetherComponent
attachment={this.props.hotspotPosition}
targetAttachment={this.props.hotspotPosition}
className={"onboarding-hotspot-tethered " + this.props.name}
offset={this.props.hotspotOffset}
constraints={[{
to: 'scrollParent',
attachment: 'none'
}]}
on={[
{
event: "repositioned",
fn: this.repositionTooltip
}
]}
>By the way, I think it would be useful to document that event system because I couldn't find anything in doc about it. Also, would find it useful to have events for entering/leaving out-of-bound/pinned state as it would permit to avoid querying class names on tether dom node |
Contributor
Author
You should be able to do that by responding to the |
|
Ok thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195.
@slorber Try this out locally and see if it works for you, OK?