Skip to content

Option to not append to the body - #192

Closed
adevnadia wants to merge 4 commits into
shipshapecode:masterfrom
adevnadia:master
Closed

Option to not append to the body#192
adevnadia wants to merge 4 commits into
shipshapecode:masterfrom
adevnadia:master

Conversation

@adevnadia

Copy link
Copy Markdown

resolves this issue: #189

@dogoku

dogoku commented Jul 22, 2016

Copy link
Copy Markdown

+1 for this PR. Just started to use it and it seems to be doing what it says on the tin.

I'll report any issues I come across, given that authors are worried about calculations not being accurate anymore, since they assume all positioned elements are in body

@TrevorBurnham

Copy link
Copy Markdown
Contributor

Closing in favor of #204.

@dogoku

dogoku commented Mar 13, 2017

Copy link
Copy Markdown

@TrevorBurnham

I don't think #192 and #204 are mutually exclusive... I have been using 1.3.3 + #192 for a few months now, but recently upgraded 1.4.0 and attempted to remove #192 only to find out my dialogs were breaking.

This PR, stops the element from changing its position in the DOM altogether, sets position: fixed and continue the calculations as if the element was on the body.

This allowed me to have the element and its parent (my dialog web-component) anywhere in the DOM, but still behave as if they were attached directly to the body, thanks to both havingposition: fixed

In order to get 1.4.0 working without this PR, I had to force the dialogs to move themselves to the body on initialisation, otherwise things would break.

I am trying to whip-up a demo which shows the issue I am facing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants