Skip to content

Strip whitespaces from element text should be - #1954

Open
emanlove wants to merge 13 commits into
robotframework:masterfrom
emanlove:strip_whitespaces_from_element_text_should_be
Open

Strip whitespaces from element text should be#1954
emanlove wants to merge 13 commits into
robotframework:masterfrom
emanlove:strip_whitespaces_from_element_text_should_be

Conversation

@emanlove

Copy link
Copy Markdown
Member

This is @jannek76 pull request with some adjustments for the changed library.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we not generate a expiry date in the future and use that instead of having to update this every year?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be good although I tend to push this off every year till it is that time of year. One problem is expiry dates can no longer be longer than a year. So it is not like we can set it so far into the future that it will just never expire.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this?

*** Test Cases ***
Add Cookie With Python Calculation
    ${expiry} =    Evaluate    int((datetime.datetime.now() + datetime.timedelta(days=330)).timestamp())    modules=datetime
    Add Cookie    Cookie1    value1    expiry=${expiry}
Comment thread src/SeleniumLibrary/__init__.pyi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants