Skip to content

Translate Is React Translated Yet? ¡Sí! Sim! はい! blog post - #409

Merged
ntishkevich merged 7 commits into
reactjs:masterfrom
lyskos97:master
Oct 7, 2019
Merged

Translate Is React Translated Yet? ¡Sí! Sim! はい! blog post#409
ntishkevich merged 7 commits into
reactjs:masterfrom
lyskos97:master

Conversation

@lyskos97

@lyskos97 lyskos97 commented Oct 5, 2019

Copy link
Copy Markdown
Contributor

Если ваш пулреквест является исправлением бага, а не переводом, то сперва убедитесь, что проблема относится ТОЛЬКО к https://ru.reactjs.org, а не к https://reactjs.org. Если это не так, то пулреквест следует открыть в родительском репозитории.

@lyskos97

lyskos97 commented Oct 5, 2019

Copy link
Copy Markdown
Contributor Author
@lyskos97
lyskos97 marked this pull request as ready for review October 5, 2019 20:31
@netlify

netlify Bot commented Oct 5, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit dfefa97

https://deploy-preview-409--ru-reactjs.netlify.com

@lex111 lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Круто, хороший перевод! Некоторые улучшения и исправления.

Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
lyskos97 and others added 2 commits October 6, 2019 10:55
* Fix typos and stylistics

Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
@lyskos97

lyskos97 commented Oct 6, 2019

Copy link
Copy Markdown
Contributor Author

@lex111, принял. Спасибо за ревью.
Хотел уточнить: как лучше переводить "contributor"/"contribution" и "maintainer"?

@lyskos97
lyskos97 requested a review from lex111 October 6, 2019 05:30
@lex111

lex111 commented Oct 6, 2019

Copy link
Copy Markdown
Contributor

@lyskos97

maintainer -> мейнтейнер
contributor -> участник
contribution -> участие/вклад (в зависимости от контекста)

@lex111
lex111 requested a review from a team October 6, 2019 10:55

@gcor gcor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Спасибо за перевод. Несколько предложений)

Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment thread content/blog/2019-02-23-is-react-translated-yet.md Outdated
Co-Authored-By: Anton Ahatov <anton@gcor.ru>
@lyskos97

lyskos97 commented Oct 6, 2019

Copy link
Copy Markdown
Contributor Author

@gcor, спасибо за ревью!

@lyskos97
lyskos97 requested a review from gcor October 6, 2019 14:38
@lex111

lex111 commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

@ntishkevich сливай, если всё ок.

@ntishkevich

Copy link
Copy Markdown
Contributor

@lyskos97 Отличная работа! Спасибо за ваш перевод! 💪

@ntishkevich
ntishkevich merged commit 4fb0424 into reactjs:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants