feat: Links in markdown when serving .md files#8274
feat: Links in markdown when serving .md files#8274icyJoseph wants to merge 2 commits intoreactjs:mainfrom
Conversation
|
Hi @icyJoseph! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This could be seen a as nice to have, but when serving markdown, the links in the content should also have
.mdin the pathname.For example https://docs.stripe.com/testing.md lists some
.mdlinks. In react.dev docs markdown pages, this would looke like,/learn/your-first-component.mdI guess, we should make those absolute too... this PR doesnt' do that currently. We'd just need to tweak the
NOOP_ORIGINlogic.I am also adding this check:
Without, locally in
devorbuild+start, I can make a request to:curl "http://localhost:3000/api/md/..%2F..%2FCONTRIBUTING"and get the root CONTRIBUTING.md document - only.mdfiles are affected, and the deployed version is protected by Vercel.