Skip to content

lower level triggerSubMenuAction wins over upper level triggerSubMenuAction - #368

Open
llambanna wants to merge 1 commit into
react-component:masterfrom
llambanna:trigger-action-localised
Open

lower level triggerSubMenuAction wins over upper level triggerSubMenuAction#368
llambanna wants to merge 1 commit into
react-component:masterfrom
llambanna:trigger-action-localised

Conversation

@llambanna

Copy link
Copy Markdown

to cater for scenario where top level items are click and sub menus are hover - similar to google docs menu UX

@codecov

codecov Bot commented Feb 11, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.53%. Comparing base (8085da9) to head (af68058).
⚠️ Report is 204 commits behind head on master.

Files with missing lines Patch % Lines
src/SubPopupMenu.tsx 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   95.73%   95.53%   -0.21%     
==========================================
  Files          11       11              
  Lines         915      918       +3     
  Branches      271      274       +3     
==========================================
+ Hits          876      877       +1     
- Misses         39       40       +1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@afc163

afc163 commented Feb 12, 2021

Copy link
Copy Markdown
Member

Test case is needed.

@delete-merged-branch
delete-merged-branch Bot deleted the branch react-component:master March 31, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants