Fix go vet ./... findings - #2
Open
randomizedcoder wants to merge 1 commit into
Open
Conversation
randomizedcoder
force-pushed
the
go-vet-cleanup
branch
from
July 19, 2026 23:51
901b99c to
1164fd5
Compare
`go test`'s built-in vet subset does not run the `composites` and `unreachable` analyzers, so these slipped through CI: - config: drop the unreachable `return nil` after the exhaustive switch in Module.UnmarshalYAML (both cases already return). - prober/dns: use keyed fields for the dns.Question literal, so it is robust to field reordering in github.com/miekg/dns. - prober: use keyed fields for the config.HeaderMatch literals in the HTTP header-match tests. No behavior change; `go vet ./...` is now clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: randomizedcoder <dave.seddon.ca@gmail.com>
randomizedcoder
force-pushed
the
go-vet-cleanup
branch
from
July 20, 2026 03:01
1164fd5 to
8dd5ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go test's built-in vet subset does not run thecompositesorunreachableanalyzers, so thesego vet ./...findings slip through the normal test pipeline:return nilafter the exhaustive switch inModule.UnmarshalYAML(both the valid case and default already return).dns.Questioncomposite literal — robust to field reordering ingithub.com/miekg/dns.config.HeaderMatchliterals in the HTTP header-match tests (17 occurrences).No behavior change.
go vet ./...is clean afterwards;go build,go test ./...pass.🤖 Generated with Claude Code