Skip to content

Build Android artifacts with a reusable workflow - #270

Closed
webknjaz wants to merge 2 commits into
python:mainfrom
webknjaz:maintenance/gha-reusable-android
Closed

Build Android artifacts with a reusable workflow#270
webknjaz wants to merge 2 commits into
python:mainfrom
webknjaz:maintenance/gha-reusable-android

Conversation

@webknjaz

Copy link
Copy Markdown
Member

This is a follow up for #265 that added initial implementation with
copy-pasted steps.

This is a follow up for python#265 that added initial implementation with
copy-pasted steps.
@webknjaz

Copy link
Copy Markdown
Member Author

@mhsmith here's the interface I envision. The references would need to be updated, of course. But it does still rely on the same API surface of android.py (CLI).

@webknjaz

Copy link
Copy Markdown
Member Author
@webknjaz

Copy link
Copy Markdown
Member Author
@mhsmith

mhsmith commented Aug 14, 2025

Copy link
Copy Markdown
Member

Thanks; I'm on holiday for the next few days, but I'll look at this when I get back.

@hugovk

hugovk commented Aug 19, 2025

Copy link
Copy Markdown
Member

Please could you resolve the conflict to point to upstream 3.14.0rc2? (As in main.)

@webknjaz

Copy link
Copy Markdown
Member Author

@hugovk is that necessary at this point, while in review? The branch has a few temporary things that should not be merged anyway.

@hugovk

hugovk commented Aug 19, 2025

Copy link
Copy Markdown
Member

Yes please, it's better if we can review it in the mergeable state, without the temporary things/FIXMEs.

@mhsmith

mhsmith commented Aug 22, 2025

Copy link
Copy Markdown
Member

I'm not sure this is an improvement. See python/cpython#137768 (comment).

@webknjaz

Copy link
Copy Markdown
Member Author

Yes please, it's better if we can review it in the mergeable state, without the temporary things/FIXMEs.

The thing is that it's not really possible to point to a merge commit that doesn't exist before the PR is merged. So I don't see this happening at this stage. That's effectively why I created this PR as a draft.

But that doesn't matter anymore since it looks I'll have to abandon the cross-repo reusability bit for now.

@webknjaz webknjaz closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants