Skip to content

macOS: Fix test_pythoninfo.GetInfoTests, stop marking as experimental - #424

Open
maurycy wants to merge 6 commits into
python:mainfrom
maurycy:422
Open

macOS: Fix test_pythoninfo.GetInfoTests, stop marking as experimental#424
maurycy wants to merge 6 commits into
python:mainfrom
maurycy:422

Conversation

@maurycy

@maurycy maurycy commented Oct 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

ref #422
@maurycy
maurycy marked this pull request as draft October 24, 2025 22:31
maurycy
maurycy commented Oct 24, 2025
View reviewed changes
Comment thread pyperformance/tests/test_pythoninfo.py
"executable (sys;realpath)": os.path.realpath(sys.executable),
"base_executable": sys.executable,
"base_executable (sys)": getattr(sys, "_base_executable", None),
"base_executable": _BASE_EXECUTABLE or sys.executable,

@maurycy maurycy Oct 24, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyperformance/pyperformance/_pythoninfo.py

Lines 84 to 92 in 74a5b03

base_executable = getattr(sys, "_base_executable", None)
if is_venv:
# XXX There is probably a bug related to venv, since
# sys._base_executable should be different.
if base_executable == sys.executable:
# Indicate that we don't know.
base_executable = None
elif not base_executable:
base_executable = sys.executable

@maurycy
maurycy marked this pull request as ready for review October 24, 2025 23:06
@maurycy maurycy changed the title macOS: Fix test_pythoninfo.GetInfoTests, stop marking Github Action as experimental Oct 26, 2025
@StanFromIreland StanFromIreland linked an issue May 12, 2026 that may be closed by this pull request
macOS failing on GitHub Actions: test_pythoninfo.GetInfoTests #422
Open
@maurycy

maurycy commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland Do you want to merge this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@maurycy @StanFromIreland