Skip to content

gh-92546: Fix _perfcheck in pprint.py - #94575

Closed
kj7rrv wants to merge 5 commits into
python:mainfrom
kj7rrv:fix-pprint
Closed

gh-92546: Fix _perfcheck in pprint.py#94575
kj7rrv wants to merge 5 commits into
python:mainfrom
kj7rrv:fix-pprint

Conversation

@kj7rrv

@kj7rrv kj7rrv commented Jul 5, 2022

Copy link
Copy Markdown
Contributor
@ghost

ghost commented Jul 5, 2022

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@arhadthedev

arhadthedev commented Jul 5, 2022

Copy link
Copy Markdown
Member

I tried to do the same fix in gh-92560. Currently it stuck on determination whether developer-only tools should be tested, so I'm porting this function to python/pyperformance (pprint branch of my fork - I can't create a PR until I fix some bugs).

@kj7rrv

kj7rrv commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

@arhadthedev should I close this?

@arhadthedev

Copy link
Copy Markdown
Member

@kj7rrv I would wait until a triager or a core developer walks by. Maybe your PR will be accepted so I'll close mine.

@kj7rrv

kj7rrv commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

@arhadthedev Oh, okay. I'll leave it.

@kj7rrv

kj7rrv commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

How long do the tests generally take?

@arhadthedev

Copy link
Copy Markdown
Member

The port is done: python/pyperformance#222. You can track it to close your PR after/if it's merged.

@kj7rrv

kj7rrv commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

So I should change this PR to remove _perfcheck instead of fixing the bug? @arhadthedev

@kj7rrv

kj7rrv commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Superseded by gh-94613

@kj7rrv kj7rrv closed this Jul 6, 2022
@kj7rrv
kj7rrv deleted the fix-pprint branch July 6, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants