Skip to content

gh-93096: Remove -t and -v flags from pickletools cli - #131039

Merged
vstinner merged 1 commit into
python:mainfrom
donbarbos:issue-93096-pickletools
Mar 11, 2025
Merged

gh-93096: Remove -t and -v flags from pickletools cli#131039
vstinner merged 1 commit into
python:mainfrom
donbarbos:issue-93096-pickletools

Conversation

@donbarbos

@donbarbos donbarbos commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

I'm also going to send a similar PR for the pickle module (for same flags)

And I'm not sure if I should send a separate PR or I can add it here

@donbarbos donbarbos changed the title Remove -t and -v flags from pickletools cli Mar 10, 2025
@donbarbos

Copy link
Copy Markdown
Contributor Author

I also made sure that unit tests call doctests, we add them here:

def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite(pickletools))
return tests

cc @serhiy-storchaka

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that these options are not documented at: https://docs.python.org/dev/library/pickletools.html#command-line-usage

@serhiy-storchaka: Are you ok with removing these undocumented pickletools CLI options?

@donbarbos

Copy link
Copy Markdown
Contributor Author

He commented this changes here: #130973 (comment)

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
vstinner merged commit 3ddf983 into python:main Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants