Skip to content

Fix make htmllive target - #124219

Merged
zware merged 1 commit into
python:mainfrom
zware:fix_doc_make_htmllive_target
Sep 18, 2024
Merged

Fix make htmllive target#124219
zware merged 1 commit into
python:mainfrom
zware:fix_doc_make_htmllive_target

Conversation

@zware

@zware zware commented Sep 18, 2024

Copy link
Copy Markdown
Member
Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
@zware zware added docs Documentation in the Doc dir skip issue skip news labels Sep 18, 2024
@zware
zware requested a review from colesbury September 18, 2024 20:39

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This fixes make htmllive for me.

@zware
zware enabled auto-merge (squash) September 18, 2024 20:45

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zware zware added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 18, 2024
@zware
zware merged commit 9a6e233 into python:main Sep 18, 2024
@zware
zware deleted the fix_doc_make_htmllive_target branch September 18, 2024 21:02
@miss-islington-app

Copy link
Copy Markdown

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <zach@python.org>
@bedevere-app

bedevere-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

GH-124221 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <zach@python.org>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 18, 2024
@bedevere-app

bedevere-app Bot commented Sep 18, 2024

Copy link
Copy Markdown

GH-124222 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 18, 2024
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
Fix `make htmllive` target (GH-124219)

Allow `make -C Doc htmllive` to work without manual venv activation

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
(cherry picked from commit 9a6e233)

Co-authored-by: Zachary Ware <zach@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

4 participants