Skip to content

gh-112205: Require @getter and @setter to be methods - #113278

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/getset-guard
Dec 19, 2023
Merged

gh-112205: Require @getter and @setter to be methods#113278
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:clinic/getset-guard

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 19, 2023

Copy link
Copy Markdown
Contributor
Comment thread Tools/clinic/clinic.py Outdated

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- could you add a test? ;)

Comment thread Tools/clinic/clinic.py Outdated
erlend-aasland and others added 3 commits December 19, 2023 11:32
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland erlend-aasland changed the title gh-112205: Require @getter and @setter to be class methods Dec 19, 2023

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erlend-aasland
erlend-aasland merged commit 6a69b80 into python:main Dec 19, 2023
@erlend-aasland
erlend-aasland deleted the clinic/getset-guard branch December 19, 2023 11:32
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
…3278)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…3278)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…3278)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants