Skip to content

gh-83004: Harden msvcrt further - #103420

Merged
erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:harden-msvcrt-even-more
Apr 19, 2023
Merged

gh-83004: Harden msvcrt further#103420
erlend-aasland merged 8 commits into
python:mainfrom
erlend-aasland:harden-msvcrt-even-more

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 10, 2023

Copy link
Copy Markdown
Contributor
@erlend-aasland

Copy link
Copy Markdown
Contributor Author

The old insert* helpers were buggy: conversion errors were cleared, insert dict errors simply ignored (could theoretically end up overwriting the previous exception over and over again).

@erlend-aasland
erlend-aasland force-pushed the harden-msvcrt-even-more branch from cb9ff82 to 88bb327 Compare April 10, 2023 19:22
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 10, 2023 20:00
@erlend-aasland
erlend-aasland requested a review from a team as a code owner April 10, 2023 20:00
@erlend-aasland
erlend-aasland requested a review from zooba April 12, 2023 08:39
Comment thread PC/msvcrtmodule.c

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing error label

@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@erlend-aasland

Copy link
Copy Markdown
Contributor Author

missing error label

Thanks for the heads-up. I removed those gotos. PTAL.

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erlend-aasland
erlend-aasland merged commit bd2ed06 into python:main Apr 19, 2023
@erlend-aasland
erlend-aasland deleted the harden-msvcrt-even-more branch April 19, 2023 14:16
carljm added a commit to carljm/cpython that referenced this pull request Apr 20, 2023
* main: (24 commits)
  pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561)
  pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545)
  pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634)
  pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633)
  pythongh-102856: Initial implementation of PEP 701 (python#102855)
  pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589)
  pythongh-83004: Harden msvcrt further (python#103420)
  pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626)
  pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314)
  pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586)
  pythongh-103583: Always pass multibyte codec structs as const (python#103588)
  pythongh-103617: Fix compiler warning in _iomodule.c (python#103618)
  pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600)
  pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576)
  pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613)
  [Doc] Fix a typo in optparse.rst (python#103504)
  pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531)
  pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039)
  pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569)
  pythongh-67230: update whatsnew note for csv changes (python#103598)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants