Skip to content

Added command create-config (#169) - #204

Merged
avara1986 merged 1 commit into
python-microservices:masterfrom
himanshus-dev:feature/create-config-cmd
Nov 1, 2020
Merged

Added command create-config (#169)#204
avara1986 merged 1 commit into
python-microservices:masterfrom
himanshus-dev:feature/create-config-cmd

Conversation

@himanshus-dev

@himanshus-dev himanshus-dev commented Oct 22, 2020

Copy link
Copy Markdown
Contributor
  • Added command functionality
  • Added tests for command
  • Added methods to dump, remove config file
    NOTE: The command by default, doesn't create/overwrite if a config file
    already exists.

Fixes #169

Changes proposed in this PR:

  • Added yaml config generator command
@coveralls

coveralls commented Oct 22, 2020 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1068

  • 76 of 79 (96.2%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.012%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyms/config/conf.py 23 26 88.46%
Totals Coverage Status
Change from base Build 1066: -0.1%
Covered Lines: 1905
Relevant Lines: 1924
💛 - Coveralls
@alexppg

alexppg commented Oct 22, 2020

Copy link
Copy Markdown
Member

@path2himanshu the coverage has decreased, can you increase it or level it with how it was?
@avara1986

avara1986 commented Oct 22, 2020

Copy link
Copy Markdown
Member

@path2himanshu the coverage has decreased, can you increase it or level it with how it was?

And fix the linters 😛
@himanshus-dev

himanshus-dev commented Oct 24, 2020

Copy link
Copy Markdown
Contributor Author

@alexppg the test coverage is back to normal now.
@avara1986 The linter breaking the build is will require to change the Command.__init__function to a major extent as the error is that function is too complex or we can make flake8 ignore it.
@himanshus-dev

himanshus-dev commented Oct 24, 2020

Copy link
Copy Markdown
Contributor Author

@avara1986 Please review
avara1986
avara1986 requested changes Oct 25, 2020
View reviewed changes
Comment thread pyms/config/conf.py Outdated
Comment thread pyms/config/conf.py Outdated
@avara1986

avara1986 commented Oct 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

thanks for the PR @path2himanshu! I test it manually and works very well 😄 but the PR need more tests, specially in the pyms/config/conf.py file 👍
Himanshu Sharma
Added command create-config (#169)
4c37dd5 
  * feature: Added command functionality

  * test: Added tests for command and helper functions

  * feature: Added methods to dump, remove config file

  * fix: Updated max-attributes in pylintrc

NOTE: The command by default, doesn't create/overwrite if a config file
    already exists.
@avara1986
avara1986 merged commit d4e8683 into python-microservices:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@himanshus-dev @coveralls @alexppg @avara1986