Fix setup.py to detect cross-compiling to ARM64 on Windows - #101
Open
maxbelanger wants to merge 1 commit into
Open
Fix setup.py to detect cross-compiling to ARM64 on Windows#101maxbelanger wants to merge 1 commit into
setup.py to detect cross-compiling to ARM64 on Windows#101maxbelanger wants to merge 1 commit into
Conversation
maxbelanger
changed the title
setup.py capable of detecting cross-compiling on windows when targeting arm64
maxbelanger
marked this pull request as ready for review
July 26, 2024 16:35
Contributor
|
@nitzmahone Matt, please merge this if it looks OK to you. |
Member
|
Wanted to get the existing 1.17.0 bits out there without making folks wait for an rc2, but this looks like a good candidate for a 1.17.1. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
cffiwithin a Windows application we cross-compile from x64 to arm64. In order to properly buildcffi, we patchsetup.pyto detectVSCMD_ARG_TGT_ARCH. We're upstreaming this fix here in case it's helpful to others.This was previously suggested by @zooba in an older issue. This is a technique also used by
cibuildwheelandsetuptoolsitself (pypa/setuptools#2724).