OM2: Discontinue OM Proto; specify PrometheusProto - #2836
Merged
Conversation
bwplotka
force-pushed
the
bwplotka/om-proto
branch
4 times, most recently
from
February 10, 2026 10:36
94f1cc9 to
40185d0
Compare
krajorama
reviewed
Feb 18, 2026
krajorama
left a comment
krajorama
left a comment
Member
There was a problem hiding this comment.
LGTM, let's see dev summit response
bwplotka
commented
Feb 18, 2026
bwplotka
changed the title
Signed-off-by: bwplotka <bwplotka@gmail.com>
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
February 24, 2026 13:16
1c3163d to
a19a068
Compare
bwplotka
commented
Feb 24, 2026
krajorama
reviewed
Feb 24, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
February 26, 2026 15:08
22e3764 to
d7fbfc6
Compare
Member
Author
|
This direction was approved on dev-summit |
|
LGTM for the protobuf part you asked me to have a look at. |
dashpole
reviewed
Feb 27, 2026
ArthurSens
reviewed
Feb 27, 2026
ywwg
requested changes
Mar 2, 2026
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
March 4, 2026 08:44
21d7a81 to
8403858
Compare
Member
Author
|
Thanks for the detailed review. All should be addressed! I improved and added missing table for OpenMetrics for consistency. Added |
bwplotka
force-pushed
the
bwplotka/om-proto
branch
2 times, most recently
from
March 4, 2026 09:12
943e1b6 to
89f2d81
Compare
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
March 4, 2026 09:17
89f2d81 to
3c45e63
Compare
krajorama
reviewed
Mar 4, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/om-proto
branch
from
March 4, 2026 11:12
3c45e63 to
1aefc37
Compare
ArthurSens
approved these changes
Mar 4, 2026
dashpole
approved these changes
Mar 4, 2026
ywwg
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/OpenMetrics#296
This proposes:
Proposed this to be a discussion on DevSummit https://docs.google.com/document/d/1uurQCi5iVufhYHGlBZ8mJMK_freDFKPG0iYBQqJ9fvA/edit?tab=t.0#bookmark=id.8x3p3zrx8mfu