observed value should be stored the bucket - #176
Merged
Conversation
whose value is same as the observed value Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
ganmacs
force-pushed
the
fix-bug-histgram-range
branch
from
January 8, 2020 08:59
7550f3b to
c931a04
Compare
1 similar comment
Collaborator
|
Hello @ganmacs. Sorry for the very late reply! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whose value is the same as the observed value
Seems to be working in v0.9.0
client_ruby/lib/prometheus/client/histogram.rb
Line 29 in 9bae725
which behavior is correct?